Re: PG compilation error with Visual Studio 2015/2017/2019

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: davinder singh <davindersingh2692(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG compilation error with Visual Studio 2015/2017/2019
Date: 2020-04-28 18:14:55
Message-ID: CAC+AXB0=+prvRgYWnc36Vfcb+v8-DSpd0fFeWHnLLDmPh20Qdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 28, 2020 at 5:16 PM davinder singh <davindersingh2692(at)gmail(dot)com>
wrote:

> On Mon, Apr 27, 2020 at 4:50 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
>
>> Bemba_Zambia
>> Bena_Tanzania
>> Bulgarian_Bulgaria
>> Swedish_Sweden.1252
>> Swedish_Sweden
>>
>
> I have tested with different locales with codepages including above. There
> are few which return different locale code but the error messages in both
> the cases are the same. I have attached the test and log files.
>
But there was one case, where locale code and error messages both are
> different.
> Portuguese_Brazil.1252
>
> log from [1]
> 2020-04-28 14:27:39.785 GMT [2284] DEBUG: IsoLocaleName() executed;
> locale: "pt"
> 2020-04-28 14:27:39.787 GMT [2284] ERROR: division by zero
> 2020-04-28 14:27:39.787 GMT [2284] STATEMENT: Select 1/0;
>
> log from [2]
> 2020-04-28 14:36:20.666 GMT [14608] DEBUG: IsoLocaleName() executed;
> locale: "pt_BR"
> 2020-04-28 14:36:20.673 GMT [14608] ERRO: divisão por zero
> 2020-04-28 14:36:20.673 GMT [14608] COMANDO: Select 1/0;
>

AFAICT, the good result is coming from the new logic.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-04-28 18:24:54 Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays
Previous Message Juan José Santamaría Flecha 2020-04-28 18:08:57 Re: PG compilation error with Visual Studio 2015/2017/2019