| From: | Osama Abdul Qader <osamaabdulqader(dot)cs(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix detection of truncated zstd-compressed backups |
| Date: | 2026-08-13 05:24:43 |
| Message-ID: | CAC+8b5j9xZJ3YKMxOzzeU88Vt8eZzzvD4mxa3yMcpmx_nvBOhQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao,
Regarding the nocfbot, I get you, and sure in my future patches, I'll make
sure to use nocfbot in my patches, Thanks for letting me know about that
and I regret for the inconvenience that occurs.
With best regards
Osama Abdul Qader.
On Thu, 13 Aug, 2026, 10:42 am Chao Li, <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
> > On Aug 13, 2026, at 11:39, Japin Li <japinli(at)hotmail(dot)com> wrote:
> >
> > Hi Chao,
> >
> > Thanks for updating the patch.
>
> Hi Jipan, thanks a lot for reviewing.
>
> >
> > Date: Thu, 13 Aug 2026 11:32:59 +0800
> >
> > On Thu, 13 Aug 2026 at 09:47, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >>> On Aug 13, 2026, at 05:56, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
> wrote:
> >>>
> >>> I have two minor comment for v5, otherwise it looks good to me:
> >>
> >> Hi Zsolt,
> >>
> >> Thanks a lot for reviewing.
> >>
> >>>
> >>> +typedef enum
> >>> +{
> >>> + STREAM_NEW,
> >>> + STREAM_HAS_DATA,
> >>> + STREAM_FINISHED,
> >>> +} pg_stream_state;
> >>> +
> >>>
> >>> This is duplicated in two files, wouldn't be astreamer.h a better
> place for it?
> >>
> >> I think this makes sense. Plus your second comment, this enum can be
> shared by all 3 astreamers. I moved it to astreamer.h and renamed it to
> astreamer_decompression_state.
> >>
> >
> > The astreamer_decompression_state should be added to pgindent's
> typedefs.list.
>
> Yes, I missed that part.
>
> PFA v7: addressed Jipan’s comment.
>
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
>
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-08-13 05:31:53 | Re: analyze-in-stages post upgrade questions |
| Previous Message | Michael Paquier | 2026-08-13 05:22:48 | Re: Fix contradictory comment for pgstat_slru_flush_cb() |