Re: REPACK (ANALYZE) within transaction block segfaults

From: Osama Abdul Qader <osamaabdulqader(dot)cs(at)gmail(dot)com>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: Alvaro Herrera <alvherre(at)kurilemu(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: REPACK (ANALYZE) within transaction block segfaults
Date: 2026-09-03 07:13:43
Message-ID: CAC+8b5gsq+W_Re-h-wYC4c2F-HCZf9FZ-rs00COFpddKjr7Q7g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Antonin and Everyone,

Greetings of the day,

I'll look into the issues mentioned in [1] and [2], including the missing
regression test changes in 'expected/cluster.out', and prepare an updated
patch.

With best regards,
Osama Abdul Qader

On Thu, Sep 3, 2026 at 10:12 AM Antonin Houska <ah(at)cybertec(dot)at> wrote:

> Osama Abdul Qader <osamaabdulqader(dot)cs(at)gmail(dot)com> wrote:
>
> > I have prepared a patch that rejects REPACK (ANALYZE) with
> PreventInTransactionBlock(), consistent with the existing restriction for
> > REPACK (CONCURRENTLY). I also added a regression test covering execution
> inside a transaction block.
> >
> > The patch applies cleanly to the current tree and passes git diff
> --check.
>
> Is this a new version of [1]? If so, I'm not sure it addresses all the
> problems mentioned in [2]. And regarding regression tests, it misses the
> changes in expected/cluster.out.
>
>
> [1] https://www.postgresql.org/message-id/49398.1787944525%40localhost
> [2]
> https://www.postgresql.org/message-id/CAHGQGwEezdMUixhJ-N0YO0OFUmh0uPaXRDkds5FS-5dmdwz4Bg%40mail.gmail.com
>
> --
> Antonin Houska
> Web: https://www.cybertec-postgresql.com
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nisha Moond 2026-09-03 07:24:54 Re: Crashes on a partition whose concurrent detach never finished
Previous Message Michael Paquier 2026-09-03 07:09:34 Re: Remove fcinfo from statistics update internal functions