Re: psql line number reporting from stdin

From: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql line number reporting from stdin
Date: 2011-11-28 17:20:58
Message-ID: CABwTF4XduTWQwe7+vpDfCW0a1aGqfBuOynnAOXsCNU16KGcE2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 28, 2011 at 8:55 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Mon, Nov 28, 2011 at 8:49 AM, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
> wrote:
> > Naysayers can always make a case
>

Should've added that I'm not one of them :)

+1 from me on the improvement.

> for backwards-compatibility, or not
> > breaking the scripts written with the existing behaviour in mind.
>
> I'm having a hard time imagining how this could break anything. What
> scenario did you have in mind?
>

Probably parsing the lines that start with 'ERROR' to report that there
were errors in the script.

>
> > Do our
> > docs have anything to say about scripts executed from stdin?
>
> If they do, we can always update them.
>

At the cost of breaking existing scripts (which I am not sure is the case).

Regards,
--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2011-11-28 17:37:11 Re: Patch: Perl xsubpp
Previous Message Kohei KaiGai 2011-11-28 17:00:45 Re: Prep object creation hooks, and related sepgsql updates