| From: | Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> |
|---|---|
| To: | PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Removing savepointLevel from TransactionState |
| Date: | 2011-09-29 03:17:57 |
| Message-ID: | CABwTF4W_sqyjfoq1XkPr+GFGKXu1LrHPsFV7GOQhR76B6ZayHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I noticed that the savepointLevel member of TransactionStateData struct is
initialized to 0 from TopTransactionStateData, and never incremented or
decremented afterwards.
Since this is a file-local struct I think we can simply get rid of all
usages of this without any risk. I visited all the commits where this
variable was introduced/used/changed and could not find any point in history
where it was ever useful. Maybe I missed something, but looks like it is a
leftover from someone's forward-thinking.
Patch attached.
Regards,
--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| remove_savepointLevel.patch | text/x-diff | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-09-29 03:28:19 | Re: pg_upgrade - add config directory setting |
| Previous Message | Bruce Momjian | 2011-09-29 03:14:11 | Re: fix for pg_upgrade |