Re: Duplicated LLVMJitHandle->lljit assignment?

From: Gurjeet Singh <gurjeet(at)singh(dot)im>
To: Matheus Alcantara <mths(dot)dev(at)pm(dot)me>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Duplicated LLVMJitHandle->lljit assignment?
Date: 2023-07-13 01:41:37
Message-ID: CABwTF4Vx=5JKVRSNZfthk8M+Quiq9DZQmzWsoo110+fxDj_BfA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 12, 2023 at 5:22 PM Matheus Alcantara <mths(dot)dev(at)pm(dot)me> wrote:
>
> I was reading the jit implementation and I notice that the lljit field of
> LLVMJitHandle is being assigned twice on llvm_compile_module function, is this
> correct? I'm attaching a supposed fixes that removes the second assignment. I
> ran meson test and all tests have pass.

- handle->lljit = compile_orc;

LGTM.

Best regards,
Gurjeet
http://Gurje.et

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-07-13 01:43:19 Re: [Patch] Use *other* indexes on the subscriber when REPLICA IDENTITY is FULL
Previous Message David G. Johnston 2023-07-13 01:30:45 Re: CommandStatus from insert returning when using a portal.