Re: Patch to make pgindent work cleanly

From: Gurjeet Singh <gurjeet(at)singh(dot)im>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to make pgindent work cleanly
Date: 2013-04-12 19:33:00
Message-ID: CABwTF4VrhXigQz7AL4-qVnLYF=iuL6mnC=N6PFg7xSxM3cLbWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 12, 2013 at 3:26 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> On Fri, Apr 12, 2013 at 01:34:49PM -0400, Gurjeet Singh wrote:
> > Can you also improve the output when it dies upon failure to fetch
> something?
> > Currently the only error message it emits is "fetching xyz", and leaves
> the
> > user confused as to what really the problem was. The only indication of a
> > problem might be the exit code, but I'm not sure of that, and that
> doesn't
> > help the interactive user running it on terminal.
>
> Good point. I have reviewed all the error messages and improved them
> with the attached, applied patch, e.g.:
>
> cannot locate typedefs file "xyz" at /usr/local/bin/pgindent line
> 121.
>

Thanks!

--
Gurjeet Singh

http://gurjeet.singh.im/

EnterpriseDB Inc.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-04-12 19:34:17 Re: Enabling Checksums
Previous Message Bruce Momjian 2013-04-12 19:31:36 Re: Enabling Checksums