| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: Non-recursive processing of AND/OR lists |
| Date: | 2014-06-23 12:15:17 |
| Message-ID: | CABwTF4V91b4bLBvSk0qX_=TuErd_YsYkxBwQhEt-EeDQdb3kGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks!
On Mon, Jun 16, 2014 at 3:58 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Gurjeet Singh <gurjeet(at)singh(dot)im> writes:
>>> I tried to eliminate the 'pending' list, but I don't see a way around it.
>>> We need temporary storage somewhere to store the branches encountered on
>>> the right; in recursion case the call stack was serving that purpose.
>
>> I still think we should fix this in the grammar, rather than introducing
>> complicated logic to try to get rid of the recursion later. For example,
>> as attached.
>
> I went looking for (and found) some additional obsoleted comments, and
> convinced myself that ruleutils.c is okay as-is, and pushed this.
>
> regards, tom lane
--
Gurjeet Singh http://gurjeet.singh.im/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2014-06-23 12:17:07 | Re: /proc/self/oom_adj is deprecated in newer Linux kernels |
| Previous Message | Andres Freund | 2014-06-23 11:35:19 | Re: idle_in_transaction_timeout |