| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: Standardize type of variable when extending Buffers |
| Date: | 2023-07-07 18:29:16 |
| Message-ID: | CABwTF4UgWCp9cxr_WOU1sGSUSdzt+Ar3z-CsPfgv9nG2kEL7uA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> Hi,
>
> This has already been discussed in [1].
> But I thought it best to start a new thread.
>
> The commit 31966b1 introduced the infrastructure to extend
> buffers.
> But the patch mixed types with int and uint32.
> The correct type of the variable counter is uint32.
>
> Fix by standardizing the int type to uint32.
>
> patch attached.
LGTM.
+CC Kyotaro, as they were involved in the previous discussion.
Best regards,
Gurjeet
http://Gurje.et
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-07-07 18:30:59 | Re: pgsql: Fix search_path to a safe value during maintenance operations. |
| Previous Message | Tomas Vondra | 2023-07-07 18:26:40 | Re: PATCH: Using BRIN indexes for sorted output |