| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Change GUC hashtable to use simplehash? |
| Date: | 2023-11-17 21:22:57 |
| Message-ID: | CABwTF4U_bbDKUKVpuvPLkeFLH51r-co4xWu795CtPrpOF2pTyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 17, 2023 at 11:02 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> I had briefly experimented changing the hash table in guc.c to use
> simplehash. It didn't offer any measurable speedup, but the API is
> slightly nicer.
>
> I thought I'd post the patch in case others thought this was a good
> direction or nice cleanup.
This is not a comment on the patch itself, but since GUC operations
are not typically considered performance or space sensitive, this
comment from simplehash.h makes a case against it.
* It's probably not worthwhile to generate such a specialized
implementation
* for hash tables that aren't performance or space sensitive.
But your argument of a nicer API might make a case for the patch. I
Best regards,
Gurjeet
http://Gurje.et
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-11-17 21:23:04 | Re: Permute underscore separated components of columns before fuzzy matching |
| Previous Message | Andres Freund | 2023-11-17 21:22:31 | Re: simplehash: preserve consistency in case of OOM |