| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Slightly improve initdb --sync-only option's help message |
| Date: | 2021-07-29 02:21:49 |
| Message-ID: | CABwTF4USUH0gW_jvOhktLX1JEs57RJ69sBKhBTWnkX2X+youBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 26, 2021 at 11:05 AM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
> Here are my suggestions in patch form.
+ printf(_(" -S, --sync-only safely write all database
files to disk and exit\n"));
Not your patch's fault, but the word "write" does not seem to convey
the true intent of the option, because generally a "write" operation
is still limited to dirtying the OS buffers, and does not guarantee
sync-to-disk.
It'd be better if the help message said, either "flush all database
files to disk and exit",or "sync all database files to disk and exit".
Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-29 03:40:09 | Re: Out-of-memory error reports in libpq |
| Previous Message | Bruce Momjian | 2021-07-29 01:52:36 | Re: pg_upgrade does not upgrade pg_stat_statements properly |