| From: | Zhenwei Shang <a934172442(at)gmail(dot)com> |
|---|---|
| To: | Afrah Razzak <mypg(dot)afrah(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion |
| Date: | 2026-05-13 05:49:31 |
| Message-ID: | CABv9HUmAh6UHwePG0PkP-suSweCJDiBcwwLjrSUbZWhVi8xZQg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Afrah Razzak <mypg(dot)afrah(at)gmail(dot)com> 于2026年5月13日周三 11:35写道：
> Hi,
>
> Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
> psql's tab completion was not updated to include it.
>
> Currently:
>
> EXPLAIN (<Tab> -- IO is not listed
> EXPLAIN (IO <Tab> -- no ON/OFF offered
>
> The attached patch adds IO to both the option keyword list and the
> boolean ON/OFF completion pattern in tab-complete.in.c.
>
> Thanks,
> Afrah Razzak
>
> Looks correct to me. EXPLAIN (IO) is a boolean option, so adding it to
both the option keyword list and the ON/OFF completion branch is the right
fix.
Regards,
Zhenwei Shang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | SungJun Jang | 2026-05-13 05:50:28 | Re: Remove invalid SS2/SS3 handling from EUC-KR routines |
| Previous Message | Chao Li | 2026-05-13 05:31:01 | Re: Fix unsafe PlannedStmt access in pg_stat_statements |