| From: | Zhenwei Shang <a934172442(at)gmail(dot)com> |
|---|---|
| To: | Daniel Bauman <danielbaniel(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Doc update proposal for the note on log_statement in the runtime config for logging page |
| Date: | 2026-05-09 06:30:17 |
| Message-ID: | CABv9HUkL+oQ57AG4xq86jr50BUMHi2ig4sshYT=yJVhbp-Tnmw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Bauman <danielbaniel(at)gmail(dot)com> 于2026年5月8日周五 23:41写道：
> Attached is the v2 patch incorporating Fujii's suggestions.
>
> -Daniel
>
> p.s. Apologies for the lack of trim on the last email. I'm new here and
> not yet used to it - and gmail hides the history making it easy to forget
> that it's there.
>
The new wording looks an improvement to me. A few small comments:
+ The logging collector does not guarantee that log messages have
reached durable storage.
+ A system crash, power loss, or an error while writing the log
file
+ can result in messages being lost.
I feel “an error” could be “errors”.
Also, there is a typo in the commit message: obviuos => obvious
Regards,
Zhenwei Shang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-05-09 06:31:20 | RE: Parallel INSERT SELECT take 2 |
| Previous Message | Chao Li | 2026-05-09 06:10:50 | Avoid unnecessary StringInfo allocation in tablesync COPY buffer |