Re: [PATCH] doc: Fix description of relative extension "directory" setting

From: Mahendrakar Srinivasarao <mahendrakarforpg(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] doc: Fix description of relative extension "directory" setting
Date: 2026-11-03 09:37:46
Message-ID: CABkiuWqY0FQnhO6xswkHEP_dEUVueJuAhBvEdDLZpB=GyW9_gw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

+PostgreSQL Hackers

On Tue, 3 Nov 2026 at 10:53, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Nov 3, 2026, at 00:34, Mahendrakar Srinivasarao <mahendrakarforpg(at)gmail(dot)com> wrote:
> >
> > Hi Chao,
> >
> > Thanks for the review.
> >
> >> I would suggest wording it more explicitly, like:
> >> or to the extension_control_path element used to locate the primary control file.
> >
> > Agreed, the sentence "in which the control file was found" could be read as the
> > "extension" subdirectory itself.
> >
> > v2 patch uses your suggested wording:
> > ```
> > Unless an absolute path is given, the name is relative to the
> > installation's SHAREDIR directory, or to the extension_control_path
> > element used to locate the primary control file. The default
> > behavior is equivalent to specifying directory = 'extension'.
> > ```
> > I have also updated the commit message to match the same.
> >
> > Best regards,
> > Mahendrakar.
> >
> > <v2-0001-doc-Fix-description-of-relative-extension-directo.patch>
>
> V2 LGTM.
>
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
>
>
>

Attachment Content-Type Size
v2-0001-doc-Fix-description-of-relative-extension-directo.patch application/octet-stream 3.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2026-11-03 09:38:10 Re: [PATCH] pgstat: Add helper to drop entries from a stats kind's hash
Previous Message Fujii Masao 2026-11-03 08:38:46 Re: PL/pgSQL: apply the too_many_rows extra check to EXECUTE ... INTO