| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Date: | 2026-07-20 08:22:53 |
| Message-ID: | CABdArM7OPvR_3KyrHtN97go9dmLvX+G-AFQMYgkvo4-jZYSQwg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 17, 2026 at 1:37 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Some review comments for v21-0002.
>
> ======
> Commit message.
>
> 1.
> Add ProcessSchemaExceptTables() to qualify each mention's EXCEPT
> entries, build a sorted signature per schema OID, and compare it
> against any prior mention of the same schema in the same statement,
> erroring on a mismatch. It also checks there are no clashes of the
> same schema with or without EXCEPT.
>
> ~
>
> IMO it's too confusing to explain the implementation detail here
> instead of the purpose. Also, it should say "with *and* without".
>
> SUGGESTION
> Add ProcessSchemaExceptTables(), which errors if the same schema is
> mentioned more than once with EXCEPT, or both with and without EXCEPT.
> It also checks that a schema's EXCEPT clause only lists tables from
> that same schema.
>
Updated as suggested in v22.
I think patch 002 is now in good shape to be merged into patch 001. Thoughts?
--
Thanks,
Nisha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2026-07-20 08:56:55 | Re: Fix RETURNING side effects for FOR PORTION OF leftover rows |
| Previous Message | Nisha Moond | 2026-07-20 08:22:31 | Re: Support EXCEPT for TABLES IN SCHEMA publications |