Re: Fix resource leak in FindConflictTuple() retry path

On Thu, Sep 3, 2026 at 10:54 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Thu, Sep 3, 2026 at 9:22 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> I agree with the idea of patch. But the patch can be improved. Before
> this patch, slot creation happened after the conflict was found. Now
> it happens unconditionally. So every call to FindConflictTuple() now
> allocates a slot and immediately tears it down. So most of the cases
> which are ocnflict-free now will do slot-allocation. I feel this can
> be optimized.
>

Good point, agree.

> Suggestion:
>
> retry:
> if (ExecCheckIndexConstraints(...))
> {
> if (*conflictslot)
> ExecDropSingleTupleTableSlot(*conflictslot);
> *conflictslot = NULL;
> return false;
> }
>
> if (*conflictslot == NULL)
> *conflictslot = table_slot_create(rel, NULL);
>

Adopted in v2, attached.

--
Thanks,
Nisha