| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Date: | 2026-08-19 03:36:37 |
| Message-ID: | CABdArM77zXKA5mq7jYD35aUEcEZgqTn0a1y=4KEmbJBG+nU4hg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 18, 2026 at 9:29 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Some review comments for patch v27-0001.
>
> (Have not finished looking at the other patches yet)
>
> ======
> Commit Message
>
> 1.
> What are the implemented rules for parent/child (inherited) tables?
> Shouldn't the commit message have something to say about those?
> Perhaps it is covered by "A table cannot be both explicitly published
> and excluded in the same statement", but even so I still think the
> rule for inherited tables should be mentioned for clarity.
>
...
Hi Peter, thanks for the review.
The code handling partitions and inherited tables is not yet fully
stable and may change as we address some optimizations and open bugs.
I’ll revisit these comments once the code stabilizes and then
incorporate any improvements or rewording suggestions at that point.
--
Thanks,
Nisha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-08-19 03:44:10 | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Previous Message | Peter Geoghegan | 2026-08-19 03:33:53 | Re: GIN VACUUM can corrupt internal posting tree pages |