| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix column privileges for pg_subscription.subwalrcvtimeout |
| Date: | 2026-06-04 05:39:27 |
| Message-ID: | CABdArM5tnrvRogzmjh+duuXPgMFGKYVdYJkdEEiqT22wsFcD2g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 4, 2026 at 7:35 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Jun 2, 2026 at 11:56 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > BTW, should we add a regression test for column privileges on pg_subscription
> > > to help catch similar issues in the future?
> > >
> >
> > +1. It makes sense because I noticed that patch authors previously
> > also omitted this part though in most cases those are caught in
> > review.
>
> Agreed. I've added the regression test to the patch.
> Attached is the updated version.
>
Thank you, Fujii-san, for the updated patch. I tested both the success
and failure cases with the SQL query, and it worked as expected.
The patch LGTM.
--
Thanks,
Nisha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | JoongHyuk Shin | 2026-06-04 05:41:01 | Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks |
| Previous Message | Imran Zaheer | 2026-06-04 05:20:04 | Re: BUG with accessing to temporary tables of other sessions still exists |