| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skipping schema changes in publication |
| Date: | 2026-03-06 11:20:53 |
| Message-ID: | CABdArM5ovXVW7o7MxEKJp4sbwmczPq_Wp5Ppfzhu=_p32ctZBA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 6, 2026 at 1:47 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the comments, the attached v58 version patch has the
> changes for the same.
>
Thanks for the patches. I reviewed and tested v58-0001, and here are a
few comments:
1) alter_publication.sgml
+<phrase>where <replaceable
class="parameter">publication_set_object</replaceable> is one
of:</phrase>
+
+ EXCEPT TABLE [ ONLY ] ( <replaceable
class="parameter">table_name</replaceable> [, ... ] )
Should ONLY be moved inside parentheses(), as it applies per table:-
EXCEPT TABLE ( [ ONLY ] table_name [, ...] )
2) publicationcmds.c
postgres=# alter publication pub2 set EXCEPT TABLE (t3);
ERROR: publication "pub2" is not defined as FOR ALL TABLES
DETAIL: EXCEPT Tables cannot be added to publications that are not
defined as FOR ALL TABLES.
The DETAIL message “EXCEPT Tables cannot be added …” could be adjusted , e.g.,
EXCEPT tables cannot be added ...
or
EXCEPT TABLE cannot be used for publications ...
3) gram.y
The comments above "AlterPublicationStmt:" should be updated for the
newly supported command.
--
Thanks,
Nisha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2026-03-06 11:51:57 | Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-03-06 11:04:28 | RE: Fix slotsync worker busy loop causing repeated log messages |