| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION |
| Date: | 2026-04-27 08:28:58 |
| Message-ID: | CABdArM4nF-QTeOsGt40NAngeeH7yJ4RVtMU4hWjVM4=fNYPrdw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 27, 2026 at 11:03 AM Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com> wrote:
>
> Hi hackers,
>
> In CreateSubscription(), the subretentionactive catalog column (declared as
> bool in pg_subscription.h) is populated using Int32GetDatum() instead of
> BoolGetDatum():
>
> This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
> ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
>
> The attached patch fixes this to use BoolGetDatum(), matching both the
> catalog definition and the ALTER path.
>
+1
This looks like an oversight in commit a850be2.
--
Thanks,
Nisha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-04-27 08:36:00 | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |
| Previous Message | Andrei Lepikhov | 2026-04-27 08:19:46 | Re: A very quick observation of dangling pointers in Postgres pathlists |