Re: Step towards being able to build on Linux (Pull request #435)

From: Vitalii Tymchyshyn <vit(at)tym(dot)im>
To: Dave Cramer <pg(at)fastcrypt(dot)com>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
Cc: Álvaro Hernández Tortosa <aht(at)8kdata(dot)com>, Pavel Raiskup <praiskup(at)redhat(dot)com>, Pavel Kajaba <pkajaba(at)redhat(dot)com>, Stephen Nelson <stephen(at)eccostudio(dot)com>, List <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: Step towards being able to build on Linux (Pull request #435)
Date: 2016-01-22 00:39:17
Message-ID: CABWW-d2qjhvnaN7nPQqr-Mso=O_xYuGnU=TJBRzHcUz2Q9=J=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Hi.

I did some research. The OSGi dependencies can be replaced to the OSS ones:
osgi-core to org.apache.felix:osgi-core:1.4.0 that is already in Fedora
osge-enterprise to org.ops4j.pax.jdbc:pax-jdbc-spec:0.6.0. This one is not
there, but other OPS4J packages are in there, so I presume this one can be
added too. Please confirm.

The only change other than dependency needed is due to a little older spec
used:

Index: pgjdbc/src/main/java/org/postgresql/osgi/PGBundleActivator.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- pgjdbc/src/main/java/org/postgresql/osgi/PGBundleActivator.java
(revision 0f979c3bbe1a36e6614e3d448ea43de7be27448b)
+++ pgjdbc/src/main/java/org/postgresql/osgi/PGBundleActivator.java
(revision )
@@ -22,7 +22,7 @@
* This class is an OSGi Bundle Activator and should only be used
internally by the OSGi Framework
*/
public class PGBundleActivator implements BundleActivator {
- private ServiceRegistration<?> _registration;
+ private ServiceRegistration _registration;

public void start(BundleContext context) throws Exception {
Dictionary<String, Object> properties = new Hashtable<String, Object>();

Чт, 21 січ. 2016 о 17:41 Dave Cramer <pg(at)fastcrypt(dot)com> пише:

> Yes, Alvaro found one that should work
> https://fedoraproject.org/wiki/PackagingDrafts/OSGiGuidelines, although I
> don't see a ubuntu one
>
> Dave Cramer
>
> davec(at)postgresintl(dot)com
> www.postgresintl.com
>
> On 21 January 2016 at 17:04, Vladimir Sitnikov <
> sitnikov(dot)vladimir(at)gmail(dot)com> wrote:
>
>> >So it seems like one solution to osgi is just to copy the sources into
>> the project. These are all interfaces, and a minimal number of files, I
>> think around 4
>>
>> What's the problem with packaging OSGi interfaces as usual rpms (or
>> whatever is used for packaging)?
>> As for me, "copy&pasting <<minimal number of files, I think around
>> 4>>" does not solve legal issues if there are any.
>> On top of that, exposing OSGi interfaces as part of pgjdbc.jar would
>> probably void OSGi compliance. The jar would just not load due to
>> invalid contents.
>>
>> Vladimir
>>
>
>

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Vladimir Sitnikov 2016-01-22 07:42:49 Re: [pgjdbc] Implement JDBC specs via pre-processor step (#435)
Previous Message Álvaro Hernández Tortosa 2016-01-22 00:26:36 Re: [pgjdbc] Implement JDBC specs via pre-processor step (#435)