Re: [doc] fix a potential grammer mistake

From: Robert Treat <rob(at)xzilla(dot)net>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Erikjan Rijkers <er(at)xs4all(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [doc] fix a potential grammer mistake
Date: 2022-08-03 16:42:11
Message-ID: CABV9wwMZ-yVBoJqYpqCx4QEe4Ni2y-mQocFjko7pe8GG_hFTuw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 3, 2022 at 11:15 AM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>
> Attachment is a corrected version based on Tom's suggestion.
>
> Thanks.
>
> On Wed, Aug 3, 2022 at 9:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Erikjan Rijkers <er(at)xs4all(dot)nl> writes:
> > > I don't think these "were"s are wrong but arguably changing them to
> > > "have" helps non-native speakers (like myself), as it doesn't change the
> > > meaning significantly as far as I can see.
> >
> > I think it does --- it changes the meaning from passive to active.
> > I don't necessarily object to rewriting these sentences more broadly,
> > but I don't think "have issued" is the correct phrasing.
> >
> > Possibly "The user issued ..." would work.
> >

Is there a reason that the first case says "just" issued vs the other
two cases? It seems to me that it should be removed.

Robert Treat
https://xzilla.net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-08-03 17:01:18 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Dilip Kumar 2022-08-03 16:42:05 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints