Re: small pg_basebackup display bug

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: small pg_basebackup display bug
Date: 2012-12-15 13:10:02
Message-ID: CABUevEztMY1abrPtHfTVyd1L3QXUaJYe8htx=WQ4JvXhn5X9TQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 15, 2012 at 11:39 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> from 9.3devel (this morning):

Is this different from 9.2 and earlier?

> There is a small bug in pg_basebackup: it displays a truncated part of what seems to be the new
> $PGDATA (the source code has 'filename' there, but I don't see what's supposed to be in there).

It is the full name of the file. If the path is too long it gets
truncated before it gets to the actual filename, of course, so it
looks to be the directory.

> The truncated name in parentheses only shows up during the filling of the new PGDATA; when 100% is
> reached that part of the displayed name is deleted. That's another bug in itself, I think:
> shouldn't the end-state of that line also display the parenthesized name?

Those are both intentional. It may be argued that the intention shoud
be changed :), but it's not a bug in itself - it's acting like
intended.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2012-12-15 13:22:11 Re: is allow_nonpic_in_shlib still useful?
Previous Message Pavan Deolasee 2012-12-15 12:42:13 Set visibility map bit after HOT prune