Re: pgsql: Fix parallel safety markings for pg_start_backup.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix parallel safety markings for pg_start_backup.
Date: 2016-05-02 14:47:28
Message-ID: CABUevEzmKq=PdKgXNQ=HmEutiKuT01YeKfhQk8buaHQFM4r=1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Oops, thanks. Need to get used to actually considering this new parallelism
flag when adding new functions, and not just copy/paste.

/Magnus
On May 2, 2016 16:44, "Robert Haas" <rhaas(at)postgresql(dot)org> wrote:

> Fix parallel safety markings for pg_start_backup.
>
> Commit 7117685461af50f50c03f43e6a622284c8d54694 made pg_start_backup
> parallel-restricted rather than parallel-safe, because it now relies
> on backend-private state that won't be synchronized with the parallel
> worker. However, it didn't update pg_proc.h. Separately, Andreas
> Karlsson observed that system_views.sql neglected to reiterate the
> parallel-safety markings whe redefining various functions, including
> this one; so add a PARALLEL RESTRICTED declaration there to match
> the new value in pg_proc.h.
>
> Branch
> ------
> master
>
> Details
> -------
>
> http://git.postgresql.org/pg/commitdiff/37d0c2cb1ab2d3da0cb9a6388450776fc31c16ee
>
> Modified Files
> --------------
> src/backend/catalog/system_views.sql | 3 ++-
> src/include/catalog/catversion.h | 2 +-
> src/include/catalog/pg_proc.h | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Ants Aasma 2016-05-02 15:15:40 Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Previous Message Robert Haas 2016-05-02 14:44:23 pgsql: Fix parallel safety markings for pg_start_backup.