| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Jelte Fennema <postgres(at)jeltef(dot)nl>, Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-02-07 12:59:53 |
| Message-ID: | CABUevEzScu5QBrrmT8fCygM-dAL+B8VD7YoyvzcAeKdNJkX4sA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 7, 2023 at 1:56 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Feb 7, 2023 at 5:16 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >
> > On 2023-02-06 Mo 23:43, Noah Misch wrote:
> >
> >
> > Well, we did talk about adding a pre-commit hook to the repository, with
> > instructions for how to enable it. And I don't see a problem with adding
> the
> > pre-receive we're discussing here to src/tools/something.
> >
> > Yeah. I don't think we are seriously considering putting any
> restrictions
> > in place on gitmaster
> >
> > I could have sworn that was exactly what we were discussing, a
> pre-receive
> > hook on gitmaster.
> >
> >
> > That's one idea that's been put forward, but it seems clear that some
> people are nervous about it.
> >
> > Maybe a better course would be to continue improving the toolset and get
> more people comfortable with using it locally and then talk about
> integrating it upstream.
> >
>
> Yeah, that sounds more reasonable to me as well.
>
If we wanted something "in between" we could perhaps also have a async ci
job that runs after each commit and sends an emali to the committer if the
commit doesn't match up, instead of rejecting it hard but still getting
some relatively fast feedback.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | torikoshia | 2023-02-07 13:02:00 | Allow auto_explain to log plan duration and buffer usage |
| Previous Message | Amit Kapila | 2023-02-07 12:56:43 | Re: run pgindent on a regular basis / scripted manner |