Re: [pgsql-www] Small issue in online devel documentation build

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL www <pgsql-www(at)postgresql(dot)org>
Subject: Re: [pgsql-www] Small issue in online devel documentation build
Date: 2017-04-11 12:49:44
Message-ID: CABUevEzCPpeVAhDiG_cw-3Ln_kBYrnBcxO4EHkpJQJYuv+qz6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On Tue, Apr 11, 2017 at 5:06 AM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 4/8/17 12:50, Robert Haas wrote:
> > On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >> What other problems do we have with pgweb that I can work on?
> >
> > Well, the 10devel documentation doesn't believe in orange. Compare:
> >
> > https://www.postgresql.org/docs/devel/static/sql-createtable.html
> > https://www.postgresql.org/docs/9.6/static/sql-createtable.html
> >
> > I think that needs to be fixed.
>
> Patch for that attached.
>

At the risk of being proven wrong again, won't this affect <h2> tags in the
old documentation as well? And if so, is that something we actually want?

> Also patch for improved note/warning/etc. formatting.
>

That part looks safer.

> Another issue I saw is that tables no longer get the fancy style, e.g.,
> https://www.postgresql.org/docs/devel/static/sql-syntax-lexical.html.
> The style selector is table.table, which is what the build produces, but
> somehow the class attribute no longer shows up on the web site.
>

It does? The output on my laptop for that produces <table
summary="Backslash Escape Sequences" border="1"> (for example). It's
wrapped in a div with class=table. But the old code had <table border="1"
class="CALSTABLE">. And AFAICT, it's the CALSTABLE that the css is actually
matching on?

Could this be a toolchain version thing? I'm using jessie on my laptop,
which is the same one that the website is built with.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Hernández Tortosa 2017-04-11 12:53:24 Re: Some thoughts about SCRAM implementation
Previous Message Magnus Hagander 2017-04-11 12:41:15 Reversed sync check in pg_receivewal

Browse pgsql-www by date

  From Date Subject
Next Message Peter Eisentraut 2017-04-11 14:30:36 Re: [HACKERS] Small issue in online devel documentation build
Previous Message Peter Eisentraut 2017-04-11 03:06:11 Re: [pgsql-www] Small issue in online devel documentation build