| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Christoph Berg <myon(at)debian(dot)org>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, pgsql-www(at)lists(dot)postgresql(dot)org, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Contributors <contributors(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Introduce contributor badges - v14 |
| Date: | 2026-11-09 11:25:25 |
| Message-ID: | CABUevEz7=mfXhnpd=z51qzgQkdnhnXX=R8VAb_aJC5FSHJWGzg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
On Sat, 7 Nov 2026 at 22:19, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
>
> On Sat, 7 Nov 2026 at 11:56, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
>> On Fri, 6 Nov 2026 at 15:09, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> > On 4 Nov 2026, at 20:38, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>>
>>> > Do we even (want to) support badges without images? Whta's the point
>>> of a badge that has no image?
>>>
>>> Requiring an image seems like a good clamp-down to reduce complexity
>>> early on,
>>> we can revisit later if a good usecase comes up (text-only badges which
>>> are
>>> applied with a CSS class comes to mind).
>>>
>>> > Why are we doing this whole exif orientation thing in the first place?
>>> Surely we can expect people to upload badges that are not upside down?
>>>
>>> Agreed, another reduction in complexity to get a base functionalty
>>> agreed upon.
>>> Rotation is also, IMHO, most useful when accepting images taken by a
>>> smarthpone
>>> which may have been held in all sorts up upside-down-left-center ways.
>>> 150x150px badge images will be generated by tools and less susceptible
>>> to being
>>> upside down.
>>>
>>> > Why do we want to support both PNG and JPG? Seems a badge should be
>>> only PNG?
>>>
>>> For such small formats, I would prefer PNG only for now. In the future
>>> we
>>> could add SVG to the list, or even pure CSS based (not for upload, but a
>>> hardcoded set defined by pgweb committers).
>>>
>>
>> SVG would allow for inling the images in the HTML itself, which might be
>> a win *iff* th eimages are small enough. Definitely something to consider
>> for an opitmisation as the number of badges grow. So bsaic support for SVG
>> would definitely be good, but let's make sure it's also verified that they
>> are "pure" SVGs and not just an SVG with an embeded raster image..
>>
>> //Magnus
>>
>>
>
> Who will actually be able to upload badges? Svgs can have code embedded in
> them so we need a good level of trust.
>
>>
Anybody can upload them, so that's a fair point. Stripping <script> tags
would be easy enough, but there is also other external entities.
Also, if you embed them with a data url as an <img> that won't happen, as
browsers prevent it. It'll be a bit less efficient, but still probably
better than PNG on account of the files being smaller?
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2026-11-09 12:04:26 | Re: Introduce contributor badges - v14 |
| Previous Message | Cédric Villemain | 2026-11-09 09:17:00 | Approval of feeds on planet.pg.org and update manager |