Re: Deal with <>s in message IDs

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Vik Fearing <vik(at)xocolatl(dot)community>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: Deal with <>s in message IDs
Date: 2014-10-31 11:11:04
Message-ID: CABUevEz1aTO5nKCbexd_d0+BHmtiQuMi-Ebo0x7i2qMdPCXbcw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Thu, Oct 30, 2014 at 7:16 PM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> wrote:
> On 10/30/14, 7:19 AM, Magnus Hagander wrote:
>>
>> > I'm not really sure this really belongs in the archives app. We could
>> > just have the commitfest app remove them on input.
>> >
>>
>> Oh, now I get it. Yeah, based on that it does sound like the wrong place
>> to fix it. Though if it's easy enough it might be worth doing for
>> convenience. I'll see if there's some place to stick a regexp that can do it
>> safely.
>
>
> Yes, my original question was if we could basically do the same thing we're
> doing now to handle /'s. See
> http://git.postgresql.org/gitweb/?p=pgarchives.git;a=blob;f=django/archives/urls.py;h=d524999dcca8a123b05c294c218d7d93977f4060;hb=HEAD#l28
> (line 28) and
> http://git.postgresql.org/gitweb/?p=pgarchives.git;a=blob;f=django/archives/mailarchives/views.py;h=f6c401a6458ee16050fcd5837a33e848d3cb7644;hb=HEAD#l557
> (line 557).

Thats actually something different - that deals with the training
slash sometimes added by django, and is done for cache limitation.
Slashes *in* messageids is independent of that. That's why I
misunderstood you :)

That doesn't mean it's not possible to work around it of course. We
have a grand total of 6 messages in our archives that have < or > in
the messageid, but as long as we only eat one of them, and only at
beginning or end, it should be safe.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Merlin Moncure 2014-10-31 14:00:52 Re: tracking commit timestamps
Previous Message Andres Freund 2014-10-31 06:41:46 Re: tracking commit timestamps