Re: pg_control read error message

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_control read error message
Date: 2018-05-18 15:55:39
Message-ID: CABUevEyuXvnCxmwc4ji376zM+j+8M+g2YzNJfBdJZsgbp4=Vrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 18, 2018 at 4:02 PM, Michael Paquier <michael(at)paquier(dot)xyz>
wrote:

> On Fri, May 18, 2018 at 03:54:47PM +0300, Heikki Linnakangas wrote:
> > Looks good to me.
>
> +1 for fixing that. get_controlfile() in controldata_utils.c also needs
> to be fixed.
>

Pushed a fix including the controldata_utils.c one.

Per Toms comments we probably have more of these, but that's no excuse not
to fix this one :)

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2018-05-18 15:56:22 Re: Postgres 11 release notes
Previous Message Arthur Zakirov 2018-05-18 15:46:30 Re: [PROPOSAL] Shared Ispell dictionaries