| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Compiler warnings with MinGW |
| Date: | 2019-09-09 12:24:22 |
| Message-ID: | CABUevEyhobjJ5i6N1esn-P1sYasnQNw4mx6d5b6To49HcauVtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 7, 2019 at 4:58 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sat, Sep 07, 2019 at 12:11:25AM +0200, Peter Eisentraut wrote:
> > I'm not sure exactly what the upstream of mingw is these days, but I
> > think the original issue that led to 811be893 has long been fixed [0],
> > and the other stuff in mingwcompat.c is also no longer relevant [1]. I
> > think mingwcompat.c could be removed altogether. I'm not sure to what
> > extent we need to support 5+ year old mingw versions.
>
> On HEAD I would not be against removing that as this leads to a
> cleanup of our code. For MSVC, we only support VS 2013~ on HEAD, so
> saying that we don't support MinGW older than what was proposed 5
> years ago sounds sensible.
>
+1, definitely.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-09-09 12:27:04 | Re: refactoring - share str2*int64 functions |
| Previous Message | Michael Paquier | 2019-09-09 12:07:02 | Set of header files for Ryu floating-point stuff in src/common/ |