Re: review: pgbench - aggregation of info written into log

On Thu, Jan 17, 2013 at 11:09 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Thu, Jan 17, 2013 at 9:36 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Thu, Jan 17, 2013 at 2:35 AM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>>>>>> This might be way more than we want to do, but there is an article
>>>>>> that describes some techniques for doing what seems to be missing
>>>>>> (AIUI):
>>>>>>
>>>>>> <http://msdn.microsoft.com/en-us/magazine/cc163996.aspx>
>>>>> Even this would be doable, I'm afraid it may not fit in 9.3 if we
>>>>> think about the current status of CF. So our choice would be:
>>>>>
>>>>> 1) Postpone the patch to 9.4
>>>>>
>>>>> 2) Commit the patch in 9.3 without Windows support
>>>>>
>>>>> I personally am ok with #2. We traditionally avoid particular paltform
>>>>> specific features on PostgreSQL. However I think the policiy could be
>>>>> losen for contrib staffs. Also pgbench is just a client program. We
>>>>> could always use pgbench on UNIX/Linux if we truely need the feature.
>>>>>
>>>>> What do you think?
>>>>
>>>> Fair enough, I was just trying to point out alternatives. We have
>>>> committed platform-specific features before now. I hope it doesn't
>>>> just get left like this, though.
>>
>> We have committed platform-specific features before, but generally
>> only when it's not *possible* to do them for all platforms. For
>> example the posix_fadvise stuff isn't available on Windows at all, so
>> there isn't much we can do there.
>
> Right - having platform specific features for other reasons like lack
> of time is a slippery slope in my opinion. We should not get into such
> a habit or Windows will quickly become a second class platform as far
> as PostgreSQL features are concerned.

Especially since there is no lack of time - the functionality is
there, it just looks (significantly) different.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/