From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Banck <michael(dot)banck(at)credativ(dot)de> |
Subject: | Re: Online enabling of checksums |
Date: | 2018-03-02 13:28:54 |
Message-ID: | CABUevEycV2mJuJGvQAe61F6V30Wf-aDA3XE2-T+HfhnZq0uO+Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Feb 28, 2018 at 10:07 PM, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com
> wrote:
> On 02/28/2018 08:42 PM, Alvaro Herrera wrote:
> > I noticed that pg_verify_checksum takes an "-o oid" argument to only
> > check the relation with that OID; but that's wrong, because the number
> > is a relfilenode, not an OID (since it's compared to the on-disk file
> > name). I would suggest changing everything to clarify that it's a
> > pg_class.relfilenode value, otherwise it's going to be very confusing.
> > Maybe use "-f filenode" if -f is available?
> >
>
> I'd argue this is merely a mistake in the --help text. Firstly,
> relfilenodes are OIDs too, so I don't think "-o" is incorrect. Secondly,
> the SGML docs actually say:
>
> <varlistentry>
> <term><option>-o <replaceable>relfilenode</replaceable></option></term>
> <listitem>
> <para>
> Only validate checksums in the relation with specified relfilenode.
> </para>
> </listitem>
> </varlistentry>
>
>
Yeah, that one is my fault. It used to say oid all over but I noticed and
fixed it. Except I clearly missed the --help.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2018-03-02 13:35:32 | Re: Online enabling of checksums |
Previous Message | Adam Brusselback | 2018-03-02 13:11:58 | Re: Synchronous replay take III |