Re: pg_stat_database deadlock counter

On Sun, Jan 22, 2012 at 19:35, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> On Mon, Jan 16, 2012 at 3:19 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Attached patch adds a counter for number of deadlocks in a database to
>> pg_stat_database.
>>
>
> A little review:
>
> - it applies with a few hunks
> - the oid you have chosen for the function pg_stat_get_db_deadlocks()
> is already in use, please choose another one using the unused_oids
> script (3150)

yeah, taht always happens..

> - pg_stat_reset() doesn't reset deadlock counter (see
> pgstat_recv_resetcounter())

Good catch, thanks!

I've adjusted the patch for that, resolved the conflicts with the
other pg_stat_database patch, and committed it.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/