Re: [HACKERS] Small issue in online devel documentation build

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: [HACKERS] Small issue in online devel documentation build
Date: 2017-02-18 13:15:00
Message-ID: CABUevEyPK3wPHvhk-UorTLAdYah0XvMJY963h1K4=wKr5o8WWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On Sat, Feb 18, 2017 at 1:44 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:

>
> Hello Magnus,
>
> The toolchain used previously (9.6) generates this code:
>> <UL
>> > <LI
>> > <P
>> > <TT
>> CLASS="LITERAL"
>> > simple</TT
>> > : use simple query protocol.</P
>> [...]
>>
>> (yes, including all the horrible newlines in the middle of tags and
>> whatnot, but there's nothing new about that)
>>
>
> Yes this is the "old" html generation with jade, which has been replaced
> by some xsltproc-based html generation. Why not.
>
> The toolchain used for dev (10) generates this code:
>>
>> <p> Protocol to use for submitting queries to the server:
>> </p><div class="itemizedlist"><ul class="itemizedlist"
>> style="list-style-type: disc; "><li class="listitem"><p><code
>> [...]
>>
>
> Yes, that the output I also have, which is somehow fine although verbose.
> In particular, there is no "c2" class involved in "ul" above...

Ah, that is correct. I thought I could see it there, but turns out that no,
I cannot :) I was clearly not awake. My apologies.

It turns out the "c2" class is added by tidy. The reason is this:
http://api.html-tidy.org/tidy/quickref_5.0.0.html#clean

There was a reason this was needed on the old docs. I honestly don't
remember what it was though, but it was needed (but many things were needed
on that source).

Turning if off makes that page work. It might break pages elsewhere though.

I've removed the flag for the devel docs build for now (or - for any XML
based docs build). I've also forced another docs load, so the results can
be checked.

Let's see if that breaks something else...

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2017-02-18 13:17:26 Re: Logical replication existing data copy
Previous Message Amit Kapila 2017-02-18 13:13:02 Re: Gather Merge

Browse pgsql-www by date

  From Date Subject
Next Message Fabien COELHO 2017-02-18 14:26:45 Re: [HACKERS] Small issue in online devel documentation build
Previous Message Fabien COELHO 2017-02-18 12:44:53 Re: [HACKERS] Small issue in online devel documentation build