| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests |
| Date: | 2022-01-30 15:45:45 |
| Message-ID: | CABUevEyJLA7y_cNr6xhd=CWG4yZiSMBi8TbzN3Tfu8ZdWA24vg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 29, 2022 at 9:44 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2022-01-17 10:06:56 -0800, Andres Freund wrote:
> > Yes, that's what I was suggesting. I wasn't thinking of using a static var,
> > but putting it in StreamCtl. Note that what pgwin32_waitforsinglesocket()
> > is doing doesn't protect against the problem referenced above, because it
> > still is reset by WSAEventSelect.
>
> Do we are about breaking StreamCtl ABI? I don't think so?
I would say no. It's an internal API and it's not like pg_basebackup
can load plugins.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2022-01-30 15:51:12 | Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests |
| Previous Message | Alvaro Herrera | 2022-01-30 15:27:11 | Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included |