Re: [PATCH] Make pg_basebackup configure and start standby [Review]

On Sat, Jan 5, 2013 at 3:41 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Thu, Jan 3, 2013 at 1:33 PM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>> 2013-01-02 11:54 keltezéssel, Boszormenyi Zoltan írta:
>>
>> 2013-01-02 10:37 keltezéssel, Boszormenyi Zoltan írta:
>>
>> 2013-01-02 10:12 keltezéssel, Magnus Hagander írta:
>> Attached is the quotes-v2 patch, the function is renamed and
>> the comment is modified plus the pg_basebackup v21 patch
>> that uses this function.
>>
>>
>> Rebased after pgtar.h was added. The quotes.c comment was modified
>> even more so it doesn't say this function is used for SQL string literals.
>
> Quotes patch applied with a few small changes:
> 1) Support for the msvc build (needs an entry added for new files that
> go in src/port if they should be used on Windows)
> 2) Makefile entries should be alphabetical (yes, that's really trivial
> nitpicking :D)

After some further modifications, I've applied the pg_basebackup patch as well.

Thanks! And again, apologies for dragging the process out longer than
should've been necessary.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/