Re: Bug during logout

On Tue, 11 Aug 2026 at 09:50, Jonathan Gonzalez V. <jonathan(at)abdiel(dot)eu>
wrote:

> Hi!
>
> Álvaro Herrera <alvherre(at)kurilemu(dot)de> writes:
> > Hi,
> >
> > On 2026-Aug-10, Jonathan Gonzalez V. wrote:
> >
> >> Django deprecated the GET method for the logout in 4.1[0] so mostly
> >> probably this was a leftover of a migration.
> >
> > Ah yeah, they removed support for GET logouts in Django 5.0 apparently:
> >
> > Support for logging out via GET requests in the
> > django.contrib.auth.views.LogoutView and
> > django.contrib.auth.views.logout_then_login() is removed.
> > https://docs.djangoproject.com/en/dev/releases/5.0/
>
> Ho! with that in mind I tracked the issue to this commit
>
> https://git.postgresql.org/gitweb/?p=pgweb.git;a=commitdiff;h=f09775acb2b3edac131e1de7863108c517262a86
> so it has been there for not so long, good thing, looks like people
> doesn't like to logout of postgresql.org :D
>
>
Yeah, I'm surprised it went this far before someone noticed.

So a few things on the patch:

1. This would be the *only* test in the codebase :) I think fixing that
scenario should be kept to a separate patch - it clearly would be good to
have them, buth aving *one* makes not much sense. Also, what's up with
enabling ESI on the tests -- then you require Varnish to run the tests
properly.

2. It seems you assign a "post" variable to the sitenav structure, whichi s
then never used because you instead hardcode the URL in the template? (FWIW
I do think using the variable is the right thing, but then it should be
used)

3. This does not cover the case of "distributed logout". That is, there are
GET links in the community auth system that does the same. If we actually
care about not being able to log out that way, we'd need to fix that too?

//Magnus