From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL www <pgsql-www(at)postgresql(dot)org> |
Subject: | Re: [pgsql-www] Small issue in online devel documentation build |
Date: | 2017-04-12 11:31:51 |
Message-ID: | CABUevEy==B3K0rBMqe7=GhSpF6SM1VTqOnrD_b0DLoFabF1yCg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
On Tue, Apr 11, 2017 at 4:30 PM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 4/11/17 08:49, Magnus Hagander wrote:
> > At the risk of being proven wrong again, won't this affect <h2> tags in
> > the old documentation as well? And if so, is that something we actually
> > want?
>
> Right. New patch with more refined selectors attached.
>
> > It does? The output on my laptop for that produces <table
> > summary="Backslash Escape Sequences" border="1"> (for example). It's
> > wrapped in a div with class=table. But the old code had <table
> > border="1" class="CALSTABLE">. And AFAICT, it's the CALSTABLE that the
> > css is actually matching on?
> >
> > Could this be a toolchain version thing? I'm using jessie on my laptop,
> > which is the same one that the website is built with.
>
> Seems so. Patch for that attached as well.
>
>
Thanks, I've applied all three patches. Your version of the color patch
also seemed slightly more appropriate than Bruce's since it only hit the
docs.css and not the global css.
Once difference I notice is that for example the "note boxes" are no longer
centered, but they do now get the new formatting. Tables now look a lot
better.
I think that only leaves the change to the javascript code that Bruce sent.
Let's see if we can figure out a way to do that one without requiring
javascript, but after that we have covered all listed issues I think?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2017-04-12 11:45:32 | Re: Reversed sync check in pg_receivewal |
Previous Message | Magnus Hagander | 2017-04-12 11:19:52 | Re: [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable. |
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2017-04-12 12:42:04 | Re: Please provide editor privileges for postgresql wiki |
Previous Message | Joe Conway | 2017-04-11 18:53:36 | Re: Edit Permissions For PostgreSQL Wiki |