| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |
| Date: | 2013-01-01 16:18:34 |
| Message-ID: | CABUevExfWskjUPUCrYs-+AVzR5noeGWEKc1-9Kq_YYCFcXqCvA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
> Hi,
>
> now that PQconninfo() was committed, I rebased the subsequent
> patches. Actual code change was only in the last patch, to
> conform to the committed PQconninfo() API.
So, finally coming back to this one.
What happened to Alvaro's suggestion of:
> It seems simpler to have the escape_quotes utility function in port just
> not use pg_malloc at all, have it return NULL or similar failure
> indicator when malloc() fails, and then the caller decides what to do.
That way we can get around the whole need for changing memory allocation
across all the frontends, no? Like the attached.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| quotes.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2013-01-01 16:35:39 | Re: PATCH: optimized DROP of multiple tables within a transaction |
| Previous Message | Heikki Linnakangas | 2013-01-01 16:12:35 | Re: [PATCH] Change Windows build docs to point to flex and bison from msys |