Re: New option in pg_basebackup to exclude pg_log files during base backup

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: "Prabakaran, Vaishnavi" <vaishnavip(at)fast(dot)au(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New option in pg_basebackup to exclude pg_log files during base backup
Date: 2014-04-09 14:57:32
Message-ID: CABUevExdLQw8VYH2OF5CeFgEUnGH1e-5_MRegjUJqiN+fyBnjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 9, 2014 at 4:55 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>wrote:

> Magnus Hagander wrote:
>
> > While pg_log is definitely the most common one being the default on many
> > platforms, we'll still be missing other ones. Should we really hardcode
> it,
> > or should we somehow derive it from the settings for log_directory
> instead?
> >
> > As a more general discussion, is this something we might want to expose
> as
> > a more general facility rather than hardcode it to the log directory
> only?
> > And is it perhaps something we'd rather have configured at the server
> than
> > specified in pg_basebackup - like a guc saying which directories should
> > always be excluded from a basebackup? So you don't have to remember it
> > every time?
>
> So it'd be an array, and by default you'd have something like:
> basebackup_skip_path = $log_directory
> ?
>
> Maybe use it to skip backup labels by default as well.
> basebackup_skip_path = $log_directory, $backup_label_files
>

I hadn't considered any details, but yes, someting along that line. And
then you could also include arbitrary filenames or directories should you
want. E.g. if you use the data directory to store your torrents or
something.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2014-04-09 14:57:50 Re: default opclass for jsonb (was Re: Call for GIST/GIN/SP-GIST opclass documentation)
Previous Message Alvaro Herrera 2014-04-09 14:55:50 Re: New option in pg_basebackup to exclude pg_log files during base backup