Re: Template for commit messages

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Template for commit messages
Date: 2016-01-28 10:53:44
Message-ID: CABUevExR7PjCY3qrL+qhFqxvDVcuH_o_JOB_mm20cZFGBdVUTQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 28, 2016 at 11:49 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> On Thu, Jan 28, 2016 at 11:30:58AM +0100, Tomas Vondra wrote:
> > Any reason why not to adapt the git message conventions from kernel?
> >
> > https://git.wiki.kernel.org/index.php/CommitMessageConventions
> >
> > I'd expect there are tools already working with that format, making
> > the life easier for us.
>
> Good idea. :-) Updated template:
>
> -- email subject limit -----------------------------------------
> -- gitweb summary limit --------------------------
>
>
> Reported-by:
>
> Bug:
>
> Patch-by:
>
> Reviewed-by:
>
> Backpatch through:
>
> I had to make up "Patch-by:" as it wasn't listed.
>
>
The original format uses the author for that (author != committer in git),
but that changes how we work a bit more. I'd be happy to just clal it
"Author" rather than "Patch-by".

I also suggest a - in "Backpatch-through:" -- since all the others are
intentionally mad ewithout a space, I assume that's for easier parsing.

They also had tested-by, it might be an idea to include that as well?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-01-28 10:56:19 Re: Template for commit messages
Previous Message Bruce Momjian 2016-01-28 10:49:56 Re: Template for commit messages