Re: file_fdw vs relative paths

On Wed, Sep 9, 2020 at 3:39 AM Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>
wrote:

> Hi
>
> On 2020/09/07 2:31, Magnus Hagander wrote:
> > On Mon, Aug 31, 2020 at 5:03 PM Bruce Momjian <bruce(at)momjian(dot)us <mailto:
> bruce(at)momjian(dot)us>> wrote:
> >
> > On Mon, Aug 31, 2020 at 01:16:05PM +0200, Magnus Hagander wrote:
> > > Bruce, I've applied and backpatched your docs patch for this.
> > >
> > > Gah, and of course right after doing that, I remembered I wanted
> to get a
> > > second change in :) To solve the "who's this Josh" question, I
> suggest we also
> > > change the example to point to the data/log directory which is
> likely to exist
> > > in a lot more of the cases. I keep getting people who ask "who is
> josh" based
> > > on the /home/josh path. Not that it's that important, but...
> >
> > Thanks, and agreed.
> >
> >
> > Thanks, applied. I backpacked to 13 but didn't bother with the rest as
> it's not technically *wrong* before..
>
> It's missing the leading single quote from the filename parameter:
>
> diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
> (...)
> -OPTIONS ( filename '/home/josh/data/log/pglog.csv', format 'csv' );
> +OPTIONS ( filename log/pglog.csv', format 'csv' );
> (...)
>

GAH.

Thanks!

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>