Re: pgcommitfest reply having corrupted subject line

On Thu, Feb 4, 2016 at 7:26 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:

> The following message, which bears "User-Agent: pgcommitfest",
>
>
> http://www.postgresql.org/message-id/flat/20160202164101(dot)1291(dot)30526(dot)pgcf(at)coridan(dot)postgresql(dot)org
>
> added spaces after commas in its subject line, compared to the subject
> line of
> its In-Reply-To message.
>
> new subject line: Re: Add generate_series(date, date) and
> generate_series(date, date, integer)
> previous subject line: Re: Add generate_series(date,date) and
> generate_series(date,date,integer)
>
> I see no way to manually alter the subject line from the
> commitfest.postgresql.org review UI. Is commitfest.postgresql.org
> initiating
> this change internally?
>

That is weird.

The CF app certainly doesn't do that intentionally - it copies it from the
archives. And if I look in the db on the cf app, it has the subject without
the space as the field that it copied :O

The code is line 355-358 at:
http://git.postgresql.org/gitweb/?p=pgcommitfest2.git;a=blob;f=pgcommitfest/commitfest/views.py;h=b4f19b2db470e5269943418b2402ca9ddfff0dff;hb=fec3b2431730c131a206a170a99a7610cdbacc6b#l355

the "subject" field in the db that we copy does not have the spaces... I
honestly have no idea where they are coming from :O I'm guessing it must be
something internally in the python libraries that create the MIME. Have you
seen this with any other messages, that you can recall, or just this one?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/