Re: Fix pg_rewind which can be run as root user

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix pg_rewind which can be run as root user
Date: 2018-04-09 19:36:40
Message-ID: CABUevEwbUnBEdquAgT5wbi5yOsJmDjMGEN5dK-TB4wy9pL27mQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 9, 2018 at 9:31 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Seems simple enough and the right hting to do, but I wonder if we should
> > really backpatch it. Yes, the behaviour is not great now, but there is
> also
> > a non-zero risk of breaking peoples automated failover scripts of we
> > backpatch it, isn't it?
>
> Yeah, I'd vote against backpatching. This doesn't seem like an essential
> fix.
>

Applied, and pushed this way.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-04-09 19:37:03 Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS
Previous Message Tom Lane 2018-04-09 19:31:08 Re: Fix pg_rewind which can be run as root user