Re: Template for commit messages

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Template for commit messages
Date: 2016-02-01 12:45:46
Message-ID: CABUevEwYnntDg7PZQ-zEtUkCdtYnf3Lm7vEwJJru9OD8tnP2gQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 1, 2016 at 1:04 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:

> On 2016-02-01 12:56:21 +0100, Magnus Hagander wrote:
> > Let's just assume that we can fix that part. As in, we can expose either
> an
> > internal db id or a short hash or something, from the archives server. We
> > could then have that visible/linkable directly on the archives page, and
> > one could copy/paste that link into the commit message. That way we can
> > avoid the long messageids.
>
> Raw messageids have the big big advantage that you can get them locally
> in your mailreader, and you can dereference them locally... I type
> esc-X id:$id<enter> and 20ms later I have the whole thread open. Maybe
> I just travel too much, but travel time is often long and uninterrupted
> and thus pretty nice to work on patches.
>

If it was a short hash of the same thing, you could equally find them
locally though, couldn't you?

> I don't really see the problem, even with gmail style messageids
> Discussion:
> CABUevEz_UJA0ddrW7apjh3Nm4p0KghwOPm0WPW4Mh_gT2-nRJw(at)mail(dot)gmail(dot)com
> isn't that bad.
>

If people don't actually have a problem with it, that of course makes it
even easier :)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2016-02-01 13:08:09 Re: Fwd: [DOCS] pgbench doc typos
Previous Message Michael Paquier 2016-02-01 12:41:07 Re: Comment typos in source code: s/thats/that is/