From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Incorrect comment in 001_ssltests.pl |
Date: | 2017-06-17 08:20:21 |
Message-ID: | CABUevEwXM0Zs0jwwg4s5tAv7cdCr0f3Ecx4nXCG28aZ=2SFxyA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jun 17, 2017 at 1:53 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
> Hi all,
>
> I have noticed the following thing:
> --- a/src/test/ssl/t/001_ssltests.pl
> +++ b/src/test/ssl/t/001_ssltests.pl
> @@ -34,8 +34,6 @@ sub run_test_psql
> # The first argument is a (part of a) connection string, and it's also
> printed
> # out as the test case name. It is appended to $common_connstr global
> variable,
> # which also contains a libpq connection string.
> -#
> -# The second argument is a hostname to connect to.
> sub test_connect_ok
> {
> my $connstr = $_[0]
>
> But test_connect_ok and test_connect_fails do not have a second
> argument as the hostname is appended directly into $common_connstr.
>
One could argue that the first sentences should just read "the argument"
once the second one isn't referred, but I can't get too excited about that.
Thus, patch applied as-is - thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
From | Date | Subject | |
---|---|---|---|
Next Message | Marina Polyakova | 2017-06-17 08:39:02 | Re: WIP Patch: Pgbench Serialization and deadlock errors |
Previous Message | Magnus Hagander | 2017-06-17 08:17:54 | Re: Typos in comments |