Re: commitfest app bug/feature

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: commitfest app bug/feature
Date: 2015-08-14 10:37:10
Message-ID: CABUevEwV4MPs-rLyD+wm_VuBc9-MkPn2b6+3Tw8rKZQB9WBvtQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 7, 2015 at 9:17 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:

>
> Hello,
>
> Some comments/bug report about the commitfest web app which just bite me:-)
>
> When creating a patch with the commitfest app, if the thread does not
> exist the application seems to reject the creation, so you may resubmit
> because you know the thread is going to exist soon... Well, this is a bad
> idea:-)
>
> Indeed the first submission, although it looked like it had failed, has
> really been created anyway, and the resubmission creates another entry. If
> you click again, you get a third. And so on.
>

Clearly I'm very slow at some things, but at least I've just pushed a fix
for this bug now. It validates the thread exists *before* it creates the
entry now...

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2015-08-14 11:47:49 Re: Test code is worth the space
Previous Message Thomas Munro 2015-08-14 09:45:33 Re: query in PostgreSQL