Re: Query cancel seems to be broken in master since Oct 17

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Query cancel seems to be broken in master since Oct 17
Date: 2016-10-18 08:05:39
Message-ID: CABUevEwP3uf_E4gWa6WqG9wKcNiAgoNyBh6ycQEyxt8z6ZT5sQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 18, 2016 at 1:00 AM, Vladimir Sitnikov <
sitnikov(dot)vladimir(at)gmail(dot)com> wrote:

> Hi,
>
> In pgjdbc we have regular regression testing against "build from
> master" PostgreSQL, and recent master builds fail for "statement cancel"
> test.
>
> The PostgreSQL as of Mon Oct 17 00:09:39 UTC 2016 was fine,
> then "statement cancel" started to fail.
> The test executes "select pg_sleep(10)" and tries to cancel it. In recent
> master builds, cancel seems to be ignored, and the statement lasts for 10
> seconds.
>
> Exactly the same driver and test version works fine for 8.4, 9.1, 9.2,
> 9.3, 9.4, 9.5, and 9.6:
> Here's a sample build report: https://travis-ci.org/
> pgjdbc/pgjdbc/builds/168444341
>
> Any hints what could be the issue?
> Was the breakage intentional?
>
>
My guess is it's related to this:
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=9e083fd4683294f41544e6d0d72f6e258ff3a77c

That's certainly not intended to break things, but that was changed on Oct
17 and it relates to cancel keys.

What platform does the postgres server run on? Can can you check if query
cancel works on libpq or if it's completely broken?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shay Rojansky 2016-10-18 08:35:42 Re: Batches, error handling and transaction in the protocol
Previous Message Vladimir Sitnikov 2016-10-18 08:00:11 Query cancel seems to be broken in master since Oct 17