| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix RADIUS error reporting in hba file parsing |
| Date: | 2021-05-31 09:31:07 |
| Message-ID: | CABUevEwO+G_JNuN5JevrjCeaJ63s14a=QbkjQp+0s978vL1XNA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 27, 2021 at 10:36 AM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
>
> The RADIUS-related checks in parse_hba_line() did not respect elevel
> and did not fill in *err_msg. Also, verify_option_list_length()
> pasted together error messages in an untranslatable way. To fix the
> latter, remove the function and do the error checking inline. It's a
> bit more verbose but only minimally longer, and it makes fixing the
> first two issues straightforward.
LGTM. I agree that the extra code from removing the function is worth
it if it makes it better for translations.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Esteban Zimanyi | 2021-05-31 09:32:19 | Re: How to disable the autovacuum ? |
| Previous Message | Dilip Kumar | 2021-05-31 09:11:46 | Re: [BUG]Update Toast data failure in logical replication |