Re: Move OpenSSL random under USE_OPENSSL_RANDOM

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Move OpenSSL random under USE_OPENSSL_RANDOM
Date: 2020-11-06 12:31:44
Message-ID: CABUevEwMa92UCWg2NDTr--0GGHimjGA5jWghm1BEnZ5qzEHmkQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 6, 2020 at 12:08 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 6 Nov 2020, at 00:36, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> > I still don't see the point of this extra complexity, as
> > USE_OPENSSL_RANDOM implies USE_OPENSSL,
>
> As long as we're sure that we'll remember to fix this when that assumption no
> longer holds (intentional or unintentional) then it's fine to skip and instead
> be defensive in documentation rather than code.

I think the defensive-in-code instead of defensive-in-docs is a really
strong argument, so I have pushed it as such.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergei Kornilov 2020-11-06 12:36:48 Re: Allow some recovery parameters to be changed with reload
Previous Message Amit Kapila 2020-11-06 11:40:58 Re: [Patch] Optimize dropping of relation buffers using dlist